perf(user-display-name): Check memory cache before trying redis - #62353
Merged
Conversation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added
3. to review
CarlSchwan
requested review from
come-nc,
icewind1991,
nfebe and
sorbaugh
and removed request for
a team
July 20, 2026 21:46
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
provokateurin
requested changes
Jul 21, 2026
provokateurin
approved these changes
Jul 21, 2026
come-nc
approved these changes
Aug 3, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
I’m surprised that cachedUsers is not a CappedMemoryCache and this is not blowing up.
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)